Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2034 add retry loop to Google symptoms data pull #2057

Merged
merged 7 commits into from
Nov 5, 2024
Merged

2034 add retry loop to Google symptoms data pull #2057

merged 7 commits into from
Nov 5, 2024

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Sep 16, 2024 •
edited by nmdefries
Loading

Description

Added retry loop to handle google api request more gracefully.
Also handles a case where a server error gets miscategorized as bad request error

Associated Issue(s)

@aysim319 aysim319 marked this pull request as ready for review September 19, 2024 17:23
@nmdefries nmdefries changed the title 2034 add retry loop 2034 add retry loop to Google symptoms data pull Oct 30, 2024
minhkhul
minhkhul approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@minhkhul minhkhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To sum up, instead or raising an error immediately like current, this PR tries one more pull if encounter backend error or internal server error. If the second pull doesn't work, error out as usual.

@nmdefries nmdefries merged commit 57368e9 into main Nov 5, 2024
16 checks passed
@nmdefries nmdefries deleted the 2034-add-retry-loop branch November 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhkhul minhkhul minhkhul approved these changes

@nmdefries nmdefries nmdefries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a retry loop for google symptoms
3 participants
@aysim319 @nmdefries @minhkhul